eth_simulate Implementers' Meeting #50

Transcript

I don't think we really have any any other to discuss. Uh Cena mentioned one thing which we could probably discuss really briefly here. I'll read it out. He doesn't have any updates. He requests that we have all clients added to the CI to ensure compatibility. And this would include clients. We talked about this a little bit last week. This would include clients that do not have e simulate implemented at all. So we can see in the output which clients are failing. And so any client that doesn't have e simulate at all would just simply fail in the in in the tests um whatever that test runner we hive. So in the hive test we want to see a column for breath and guess and error gone. And some of those will just blanket fail and that's okay.

Um because it gives us something we can point people to and say hey you guys your tests are failing. You should go fix that. I don't think the current test should support that because if I think if one clients Oh, I'm sure the CL actually supports it. It's just regard that the clients build and that's very quite annoying because the clients tend to change how they are built like I have been fixed many times and never mind many times. So if you add that kind of clients then we always need to maintain them all the time. That's really annoying. Well, so this I think he's referring to um we just put all the mainline CL clients in which Hive already has to support and so we would just basically But we have to build

those. We have to build them. Yeah. Isn't this part of Hive? Isn't this a fully automated solution that people over hired by EF handle? Thank you. I thought this whole thing was I'm not sure but it hasn't been like that because they had to update some other version and other systems. Right. So I think the reason we were having to manually update was because we weren't pointing at the released consensus clients. We were just pointing at um older versions. I think if we switch over to release clients then we benefit from all the automation.

see all the build automation that consensus devs have for their whole setup and so anytime I think I think one challenge is that that we also pull request so we haven't been merged with those tests and if they would merge those test then everyone else would kind of keep it updated but now every time some new version comes out then we need to kind of update from there and again they there's often conflict as well to fix yes so this this was the context of conversation was Cena would like to get things merged and one step of that is enabling all the clients in the test suite.

Yeah, I think what one reason why Cena didn't want to do that before is that because I think we would we didn't want to run it against those clients that are not going to working towards this and I think if we added there somehow then it would be assumed to be default that you had to the the whole high test fails if if they're not supporting each simulate. I think that used to be the case. Oh, I'm sure I don't I'm not sure how how that works nowadays if they have kind if there's that kind of like optional support features that don't have to fade all the test just simulate fails. But yeah, I guess I can discuss Cena about this.

Yeah. Okay. Let's talk to Cena maybe in Telegram and get the details. Okay. See you later. Yep. See you later. Bye.