EIP Editing Office Hour #97 (EIP + ERC)

Transcript

[music] >> Welcome to EIP editing office hour

meeting number 97. Today is April 14th and the issue is added to ethereum/pm GitHub repository and the issue number is 2017. On agenda we have PRs to move into review status and some on the draft as well as a couple of them in the miscellaneous. We are joined by editor Joachim. Uh Joachim, please feel free to take a look at the PRs. We are also joined by the authors, some of the authors, so maybe we can address to the PRs and their respective question.

Cool. Okay, let's let's get started. All right, to [music] review let's see. Right.

Well, I mean this all looks looks Let's see what [music] Sam asked here. Mhm. Okay, what is added? Yeah, all right, let's move this to review. Okay. Cool, let's see. So, we are also joined by some of the authors, but uh since we have less PRs, so maybe we can go sequentially, no problem at all.

Yes, yes. And let's see. Mhm, if I got let's see because We do have We do have author for this PR. Um Cyber Sentry, if you have any question for him. Yeah, yeah. Yeah, like because I see that 8004 is now in the required EIPs, uh but this is an ERC. Uh and now I'm confused. Is this Is this actually correct? Does that work?

Uh yeah, that's that's correct initially. We would facilitate in the registration internally. So, what we then did was after community feedback we then um looked to integrate with 8004. I see. Is it Oh, wait. Oh, I I sorry, I'm so confused. I now see that this is an ERC and not an EIP. Okay. This makes This I thought it was an EIP and then I thought it was linking to ERCs. Okay, [music] great. Yeah.

All right, yeah. Uh okay, this this diagram [music] um doesn't exist. So, I think you maybe forgot to >> Yeah, it's in the it's in the the assets.

It's on another pull request and um I know that Sam looked at that last week, so it's sat there ready in um in assets, not in not in this pull request. It's in a separate one that was automatically merged. Ah, okay. Um for this, could you then could you maybe rebase it or merge it on top of master so that we can also check like the end result? Yeah, I'll I'll dig it out now and shall drop a link into the um into the chat. You'll be able to see where it's actually on there with the the other assets for this ERC. I'll quickly dig it out now.

Yeah, yeah, yeah. Uh yes, okay, I see it's there. [music]

Yeah, if you could um if you could rebase this PR just on top of master like I know if you merge it that it it would then work. Cuz I just want to to verify that. So, if you could rebase or like merge master into into this [music] PR, then we can see what um Yeah, this picture should should resolve. Yeah, good just to confirm then so drop the the asset into the same pull request. Should I do that now? No, no, because Oh, wait. Sorry, this [music] is Yes, this is on master.

That's what I would do here because um this commit is Oh, wait. You want if you two commits. If you rebase this PR on top of master, then um we can also you would basically also import the uh this uh this image. yeah, yeah. Yeah, with the with the image, I do

recall when I actually did that initially, um it wouldn't go through the checkers, the HTML proofer. So, I had to add it on a separate branch. Um But, if you would rebase this PR on on master, so get three base uh on the latest master. Yeah. Then, that should that that this should >> Yeah. Because if you would insert it here, then uh if you would merge to master, then I think it will complain because that file already exists on on master.

If you would do this, this should work. Yeah, I'm just um just updating now. Uh yes. Cool, cool, cool. Hm, we still don't see this image, I

think. Like, why is this? Why is this? Okay, that's great. Uh I see. [music] Okay. Yeah, okay. And I now understand why you can see see this because it is on your fork and not on on the repository.

>> [music] >> Um Yeah, how do we check this? Yes. Uh okay. Um so, this image is it So, this already been merged or not? Let me see. >> Yeah, so that that image is already been merged into master. It went through automatically.

>> And then, I tried to originally add it to to to this fork, but then when I tried to put it through, it couldn't recognize the file. And then, it failed on the checkers. So, wait, wait. Yeah, I think because Hm. But, do you do you know like uh I would say that this would be the correct one? And I also recall that all the ERCs get [music] renamed to EIP.

Do you remember that? >> that's um that's right. It asked me to put it on um on the dot md as a >> EIP, Mhm. but actually to put it in the folder ERC. Yeah, I think the validator bot is using it as a EIP, so we use that. as an EIP even if it is an ERC. I mean, I'm assuming that if we approve this PR, finally the rendering will include both images. I wonder if we can quickly check because the asset file has already been merged, is it visible on eips.ethereum.org

even if it is in draft status? Right. Oh, that's a good point. Because Yeah, I think that's that in the draft this picture was not [music] there, but let's check. I don't know. Yeah, okay. It's the old one on on the the changes for this haven't automatically gone across. It was on a separate fork.

Yes, yes, yes. Okay, let me quickly check locally how this then works with the ERCs. Okay. Okay, so I just checked in the in

the repository, it's indeed an EIP. Okay, so I'm going to trust that this works. I also think that the bot checks this. So, okay. So, that that [music] that's that's fine. Okay, let's see where where I was writing. If it can be verified that the asset that we are trying to render here um is already rendering on eips.ethereum.org, then perhaps when we approve this proposal to move into review status, that will automatically um like sync with the master branch.

Yes, yes, yes. Let me quickly see how we can [music] actually check this. Because where is it going? Okay, great. Yeah, that what you're doing now is the exact same as what what I did to run a check. Uh and I just I just followed the exact same. As you can see, it's down as EIP- and then the um Yes. the ERC. I did the exact same. Yes, yes, [music] yes. So, this should then load. Oh, wait.

Yeah, okay, great. Great, great, great. Cool. Okay, let's see if these titles are correct. >> These

>> These tests like are they complete? Because I see only this part [music] has been written and not this part. Sorry, can you just repeat that one, please? Yes, yes. So, like these tests, is it Is this complete? Um because it does not run this one. Yeah, for me they were complete.

There was one addition um since you initially looked at it. Um and that's the the one underneath it. Okay, media content verification. And that's just something a new vulnerability that um came up as we were developing that we wanted to capture. Okay, I see. I see. All right.

Yes, this looks [music] good. The only thing uh could you add to this part of the specification the URLs for these RFCs? Let me quickly see if I can get this from another EIP. I can now write the edit. This

to Okay, so one one final comment to to just add these URLs. And then we can uh we can merge it. Yeah, got it. I'll quickly work on that one now.

Yep. Cool, cool. All right, [music] let's see the next one. Where is it? Let's see. Oh, well. Okay, fine. This is an an easy one. Indeed for us. Yes, yes, yes. So, for the next we are joined by the author [music] Gilon. In case you have any question. Cool. Thanks.

Okay, I will also add ask I will add this comment here. Um to add these URLs, but I mean this this looks good. Okay, let's see where these are the reviews which I [music] just Yeah, I think we are done with the reviews with that. Like 1660 was the last one. Yes, [music] yes. All right, this one was merged. Okay.

Cool, cool. Then we leave these open. Let's see. Open license link. Should be correct. This Okay.

Cool, cool. Yeah, we can skip that one. I think it's waiting on Sam's approval because Sam is one of the author. The next one is mine. I don't know why it is uh stuck there. Maybe if if you can quickly take a look, we can understand the problem. Um I tried to give the relative link, but it did not work. So, Sam updated it again. Again, it is [music] stuck there.

Okay, let's see what is going wrong. Does it Okay. No relative link. If you take a look at the previous comment by Sam, he had actually added the link because >> I did make this change. All right, [music] let's see.

That's looks That's weird. I'm in I'm fine if we want to take it async. I know there are more authors join. This is my proposal. I can connect with you later. Maybe we can move on to other proposal and look into the issue. >> Yes, let's let's [music] do that.

Okay, next we are joined by um Greg for static control flow. He has some questions. I think he has added a comment in the agenda. Need to discuss what needs to change. Greg, please feel free to share your question again. Good morning.