EIP Editing Office Hour #9

EIP Editing Office Hours · 27 Dec 2022 · 26:40

Meeting 9 of the EIP Editing Office Hour, held on 27 December 2022. EIP editors and proposal authors work through open pull requests and questions about the Ethereum standards process. This meeting covers EIP pull requests heading to Final, Last Call, Review and Draft along with miscellaneous pull requests.

Topics

From EIP Editing Office Hours, hosted by ECH Institute.

Transcript

welcome to EAP editing office our meeting nine I have shared a Chennai chat we are joined by a couple of EAB authors to discuss a few proposals the first one here is to move to review and the number is 6059 uh the pull request number would be here is six two two one six zero five nine is the EIP number so thank you Sam for joining Sam if you would like to screen share and maybe yeah start reviewing the proposal we are joined by author Stephen here sure yeah I can do that uh see if I get my screen share to work

here what did you say the EIP number or the pull request number was again six two two one did you have any specific questions while I'm trying to get my screen screen share working Stephen we can't hear you if you're talking uh if you have any specific question on this beer please feel free to share can you hear me now

yes yes we can uh okay thanks so no no questions we just would like to to get this to review and get our reviewer assigned sure yeah I can I can do that um so generally speaking um authors are responsible for finding their own reviewers I'll set a peer reviewer from our list but um generally speaking they do a pretty light look so far so uh but yeah how is that process I I wasn't aware oh sure so um you move your EIP from drafting to review like you're doing here and then um this is when you as an author will go

out and find um people who are relevant to either implement it or give feedback on it um the the move from draft review kind of signals that you don't expect the EIP to change very much anymore and it's ready for people to start playing with um so in this case uh since it's like a non-fungible token um there's a working group that I'll I'll share the link with um you might want to look on say the openc Discord or a few other like uh you know nft related places and see if anybody there would like to review for you um and then whenever you think that your EIP is ready you can move it into last call

okay that's great thanks son okay and the next proposal okay you're looking into it okay let's finish this one first now I see what's going on here so

yeah it looks like Panda wants you to change how the list formatting works so you'll probably want to do that before moving into review um I don't know where that is in here but um yeah okay so I think what's going on here is that it's um yeah so it's restarting the list every time so if you want you can indent these so just um I think it's two maybe three spaces uh or you can use the backslashes

that Panda's suggesting and it'll actually put them into the list for you so it'll um yeah you see you should probably fix that first and then Panda will probably merge it once once you make that change okay okay all right the next one is pull request number six to two zero um it's a new draft proposal foreign

so generally speaking we we like people to remove the build system configuration um so like you're prettier config okay yeah it's it's not necessary for the reference implementation so okay I'll remove it yeah and obviously the the hard hat and package.js and yeah um okay let's take a look at this uh pull

request so have you looked at other eips that are kind of been the same in the same family uh yes we've we've been working with the actually the two eips which are needed for this one one for multi-assets and one for nestable nfts so there were a couple of other wish uh Implement

something similar on nesting but we are in in the other rationale we explained how the nestables is different and this one utilizes the the other two okay foreign quick read it seems fine like a you're

following the format well and all that um I don't want to get too in depth in in actually reviewing it right now just because um I don't know we're we're on a call um and I don't want to put all you understand it yeah um but no it looks good um yeah um yeah the purpose today is for it to be in your radar so you can check it uh someday probably next year yeah I'll uh I I will get around to it so um yeah thanks for for proposing and yeah it looks good so far okay thanks a lot of time for the

comments as usual wherever the next one is um PR number 6051 the author is here but it seems like it is merged right now a few minutes ago okay so um yeah VG if you have any other specific question related to this proposal feel free to ask uh no uh it's a good no okay cool very good thank you all right um and uh I do not have any other specific number for discussion so probably we can pick up from The Proposal in the last

call which is 6185 sure thing thank you and then so the 27 so we want you to go to the 10th and is there anything else in this one um

okay okay 56 15. and 53.80 yeah I think that looks okay

so 5507 I think I already looked at this one I'm confused foreign um

okay 557 61.50 foreign 57 yeah so

61 15. okay okay standard show fine um

foreign I don't care

that seems fine all right so that was 165. token transfer by social recovery okay

okay foreign yeah so this can't really go anywhere

because this still needs to be written a little bit right yeah the idea is very fresh yeah and yeah okay so there we go so 583 foreign

there's something weird with this one what's going on I guess not they just listed as an author without uh an email address I guess you can do that transfer right into a new world guard so I think people are discussing again uh on having ens as an author name yeah yeah I saw that comment um for the time being I don't think that we can I mean we could do it but it would just be the same thing as email right except that it would provide no way of

contacting the person um yeah yeah I mean I remember earlier it was mentioned that we should have at least one email address if it is like with the multiple authors and if there is only one author and he or she chooses to have any other name they can go with it but they should have email address as well to be contacted yeah yeah I mean yeah it would be nice to be able to contact people but I don't like I don't want to force people to put an email address that's publicly available because it's just gonna get spammed

anyways I don't know something to think about discussion board can be used as the contact right that's very true this is

foreign things

foreign ers foreign ER and guard us follows

um I'm missing one SBT what is it for a soul bound token okay yeah got it thank you foreign

this exact EIP before or at least something very similar um reference implementation thank you nice foreign

cool um so the next three proposals um six one eight eight six one eight nine and six one nine zero all three are related to self-destruct proposed by Panda babe yeah I've gone through those a few times I'm still working on those okay then this seems to be a short call for today I mean it was a holiday time so yeah probably this is it for today unless anyone else has any funny question comment for Sam happy holidays you too thanks for coming out Everybody Take Care thank you

everyone bye bye