EIP Editing Office Hour #8

Transcript

welcome to EIP editing office our meeting a I have shared agenda and chat again here for reference of people uh so we have two authors here we can start with PR number 6059 over to you Sam all right so let's just share my screen here foreign there we go so I think 6059 is basically good to go

um just a few grammar things and like uh a comment about the word propose in the I think it was in the abstract um just because it's not a term I'm familiar with and um I think if you're introducing something in your PR uh or in your proposal you need to Define it before you use it so just that and then it should be good to go okay that's great I just I hadn't seen the last comments it was just a few minutes ago right yep okay we'll get that done and we'll let you know sounds good awesome that was fast thanks all right uh the next one is uh pull request which is waiting to be merged into a final proposal the number is 6076

sure let's take a look okay foreign over there

okay so let's just putting it in HTML fine yeah okay that all seems good and then so what was the rendering error here so this is 45 19. 19.

oh yeah it just doesn't pick it up here but it does here that's really weird yeah well okay so now let's just see how the discussion is doing foreign okay

foreign comment was resolved yeah okay seems fine to me actually I hear okay yeah so if you want to um I'm just curious if you want to merge

it first as like as last call without changing the deadline and just make sure it renders correctly and then we can move it to final um just because once it goes final we generally don't allow changes so it might be best to make sure everything looks good before um before going to final um but if you're if you're sure it'll look good then I can merge it like sorry for I have a very bad level of English and can you repeat more slowly please oh sure sorry so uh once the proposal goes to final we no longer allow changes yes um so it might be a good idea to

um make the HTML changes without changing the Status to final so in in different pull requests or uh yeah so here I can um if I do this and then do um do that and then okay we may want to change the last call date

again because this is already December I'm I'm just suggesting we don't change anything just so we can make sure it renders correctly and then like later today I can move it to final okay but for moving it to final we might want another PR right yeah we will definitely want yes yeah so it'll be like we merged this one with this suggestion and then we make sure it renders correctly and then a new PR to move it to final all right so yeah Javier when it is merged you can immediately create another pull request to move it to the final status yeah I just want to make sure everything looks good before we go to final

okay any more question you have Javier uh no I think yeah I think I think this um because I remember reading this uh like initially I think it's you know it looks great I think you've done a good job on it so yeah foreign thank you I think we have three more proposals which are waiting to be moved into final the next one is six zero six two PR number 6062 .

all right foreign foreign

foreign must point to a Json file that can confirms yeah so this needs to say okay I think otherwise this is fine

all right so we have 57.57 oh nice I mean I'm okay with this yeah we have been waiting for this proposal for some time I love moving my own eip's to final it's great okay congratulations yeah 481 so what's this one last call for six months should be final already yeah probably what do

we got going on in here [Music] um yeah okay so let's just eats some some help here so this needs to be foreign just this I think um so then this

okay oh God damn it so the author needs to be removed foreign okay [Music] then that's called deadline HTTP remote foreign

to a particular commit so then we need a paranoid like so on there we go

I can't suggest on this one um that's fine that's fine let's be changed it's fine it's fine it's the actual thing it's like yes capital c okay foreign

all right foreign otherwise is that the right one let's find out

nope that one's merged it is 1691 all right so there's that most we need yeah foreign to review

so yeah we have now three more review proposals if you would refresh that yeah sure okay all right what's going on here it's review status yep approved what needs to be changed here now is this a

okay so this is four nine three eight so this is a little get no data so that's easy enough and that's infuriating it's one line too far away okay so um okay then we have

um so you're linking to 4844 and let me guess 4844 probably has dependency on 4938 it doesn't okay so um foreign sometimes

so a question here some uh this eapw bot is a designed in a way that for required section proposals which are in final starter should be there or in any uh active status is it uh so it's like there's like levels here I can pull it up here um so here it is so it's a kind of says here like a final EIP um can link to sorry a last call EIP can

link to last call final withdrawn living a review EIP can link to review that like it kind of defines like an order uh of which they're allowed to link to each other so as long as um you're in the same level or or below you're allowed to like do it um another follow-up here why withdrawn because where John may or may not have reached towards the final status right uh so withdrawn is is terminal so once it's withdrawn you can't take it out of withdrawn again right but can we have that and have that proposal in request section because that okay I mean maybe maybe we shouldn't but yeah uh that's probably uh but what can you withdraw Optical draft

or can you withdraw after review you can withdraw whenever you want yeah whenever yeah yeah so that's my concern here like withdrawn uh that does not uh like it is an abdominal status but it does not specify that proposal has uh reached to the status where it should be and it is eligible for being you know in the required section I mean maybe maybe a different uh discussion for a different day but yes it's yeah that's something that we should probably make a rule about like an active EIP you shouldn't be able to depend on a withdrawal one yeah yeah it's interesting yeah that'd be worth it like an issue somewhere if you wanna write it down what is a living

uh living is what eip1 is so it's like eaps get updated yeah they don't you don't see many of them okay okay well thank you for sharing that was interesting to learn about yeah all right so that's easy enough um so that was 30 61.

60 31 rather now point four four okay yeah so this is the one that needs to happen first um what's the problem here okay okay yeah so it's just a um yeah so I should go back to the other one and remove that comment what's this one I hate that you can't uh

delete comments if they're attached to a pull request it's annoying okay so 4844 so why isn't this one going ahead so status change okay this craft Okay so if the only problem is yeah so it's a similar thing

um to 60 50. it now [Music] 1691

. all right so that should help maybe we should look into 1691 if that is a blocker yeah I can't uh I can't merge it it's my proposal okay yeah then we will discuss it tomorrow let's see if any other editor may watch it yeah I don't actually know why um nobody's approved this it's really short um okay so we're moving to draft okay

yeah okay so it's just missing thank you okay so 4K checks based on timestamp so what's going on with this one again okay and then

yeah so access doing a pretty good job on this one I don't think yeah it's just still being worked on so we can move over that one universal router what is this all right what's going on here okay so we can assign this uh wait we have a the markdown thing we're supposed to use now right let's go and find that big template

um well for now I'll just do this and then I'll figure it out but I remember um Matt was talking about creating a hack MD file to just keep track of the number oh number yes that's right okay so this should just be 20 7 21 .

[Music] now foreign foreign

[Music] foreign okay steps okay motivation

okay neat um you need four ticks [Music] foreign [Music]

let's see it's okay you probably want to make this okay that's what it says the contract you versus Reddit

okay that's fine and then foreign [Music] to review all right so there's Universal router

so uh Sam it looks like author for a pull request 6076 have made all the changes that you have suggested if you can maybe take a look again yeah you can probably merge that all right so so why didn't you merge now because okay so over here my little clear pan Pips review I think so that I think this should just merge

yeah and then we will take a look at how it looks when it's rendered foreign to see the pages deployments anymore

they always they always disappear but uh okay we'll have to come back to this at some point all right so just to make sure the next step for the author here is to if everything goes fine and the page rendering as well he has to just make another pull request to make the status change to final yep assuming that everything renders nicely exactly yes okay we we have been joined by another author and the pull request number is 5135

in the draft status it is okay okay foreign just be

the standard did you have any specific questions or um should I just go through this uh uh thanks Sam uh you can just go through one particular question is about calling calling the these ratings a token uh or just ratings um I think if you want to call it just ratings or whatever that's up to you um I I do see where panda is coming from but as if you just tell them um you know we'd like to keep the name ratings um he should clear his review um

because like we we can't force you to pick a certain title or something as long as it's descriptive um so yeah just if you want to go with ratings just you know say so on the pull request and yeah okay uh yeah so just um in here whenever you use your own EIP number um just use like this proposal instead because um that's the style we use okay [Music]

yeah that's what you're getting these like uh these errors here is just because you're referring to yourself um right yeah yeah I'll remove all that yeah P20 good good good that looks good um I like the new name new operator is uh it's a good change thanks yeah and I think um you know I think rating is a a decent description for something like this um I think it's more generally like uh more well known than experience points

um so yeah I think that's that's fine um yeah also you can have a negative rating but you can't really have negative experience points yeah you can't it's like unlearning something yeah no that's good it's good okay so this this is actually quite a bit of changes so I'll add this to my list of things to look at offline um just because I don't think I'll be able to get through it um on here um yeah I can get through some of the basic things though and throw in another commit so you don't have those errors okay yeah so yeah just put it on my list

of things to look at um and I should be able to get to it either to later today or probably on Friday um yes I don't worry too much about getting a commit in like right away sounds great thanks Sam and then um if it's okay then then what would be the next step uh so what are you in you're in draft right now are you in draft yeah okay so um I'll probably grab a so we've started like a new peer review program um so I'll probably grab a volunteer from our list and assign them to your uh your proposal

um hopefully they'll have some useful feedback I I don't know if they will um and then uh whatever you're ready like if you think the proposal is uh ready to move forward um like you're not expecting any more changes you can just submit a PR to change status to review um and that's a decision that you make um when you're ready and then we'll approve it it shouldn't be a problem assuming everything else is fine um and then uh try once you put it into review try to collect feedback from other uh groups or organizations or individuals who might be uh interested in this proposal so like who do you expect to use these ratings um who do you expect to display them do

you expect wallets to care about it and try to get uh reviews from those kind of people and once you're satisfied and and think you have a solid um proposal then you can move forward into the next stage after that foreign [Music] right here oh in the discussion thread okay cool yeah we try to keep it all in one place um and this is this is like once you go into review this is when you try to get other people to try implementing your EIP so you might reach out to like you might do like an open Zeppelin PR or something like that like

um yeah that's pretty much the the process you want to get everything worked out in review um before you go to final because once you go to final you can't change anything so right yeah all right yeah I've got a couple some folks have reached out with interest to to start using it now that it's almost they're probably not going to be many changes it'd be you know maybe they can get started trying some of those things out yeah exactly and then if they have any feedback you can incorporate it back in

like a big thing is when you have like other people implementing your standard they're going to have questions and then it's really good to get the answers to those questions back into the the document right yeah and that's what the process is for right yep ideally yeah cool so yeah just just to reiterate one last time it's this is like a u driven process so when you're ready to move it feel free to move it we won't touch it if you don't so cool well I'll um then I'll get that committed and and wait for any more uh feedback from you and then probably move forward uh next week or depending on how close to the the

holidays things get maybe even or uh later yeah all right um yeah I know it can be a slow process so thanks for bearing with us yeah no problem thanks Sam no problem all right next one is from stagnant to draft yeah yeah this one here okay yeah so this is just waiting for

validator errors so that can just sit there and then we have 725 improvements okay validator errors okay so they may have fixed them okay starting to draft simple summary to abstract okay yes and consists of so 725 y so does keep 725y

all right this needs to be in split view because this is a lot of changes let's see okay someone okay erc735 X okay and x and then Y and then Y is interface Okay so we can go up here and we can say um

substandards the MC 725 y um generic execute function ERC 725 X um okay

okay this channel requires ERC business should be three and then we need to see you're gonna see one seven three what are they linking to they aren't linking to it at all I guess yeah um so let's edit this p173

okay you just put this in that from six five times [Music] and there's an additional references

thing so between six five oh um cool there we go oh actually there was one other thing

okay so it's 175. 1693 customers okay interesting one of these fixing things good comment down all right so it's actually number three customer use tokens against customer errors for common token applications I think they had a hmm

all right I can't say standards for common tokens foreign

structured errors for common tokens actions so clients Implement their scheme expression okay Define

Theory why which were very reasons custom arrows good okay okay okay foreign rules backwards compatibility revert

strings reference implementation yeah I mean that's that's awesome so cool and that's probably all the time we have for today all right uh Sam I just wanted to let you know

um maybe you can take it um offline for proposal four five one nine uh the pr number 6076 that we have just merged Arthur has created a new PR 6124 to move it to final okay so it did render correctly there was this one here I think okay okay that looks good yeah that seems fine to me all right let's go so the pull request number is six one two four foreign

cool well congratulations right well thank you everyone for joining thank you Sam for um taking our time to help all new Authors um okay uh so for the next meeting I uh I I spent the calendar it is planned on 27th so do we want to keep it or do we want to have it in the new year um I mean I'll try to show up so feel free to keep it I don't know if we'll get any anybody coming but all right so we'll try to keep it on 27th thank you everyone