EIP Editing Office Hour #40
EIP Editing Office Hours · 9 Jul 2024 · 1:01:07
Meeting 40 of the EIP Editing Office Hour, held on 9 July 2024. EIP editors and proposal authors work through open pull requests and questions about the Ethereum standards process. This meeting covers EIP and ERC pull requests heading to Final, Review and Draft along with miscellaneous pull requests.
Topics
From EIP Editing Office Hours, hosted by ECH Institute.
Transcript
welcome to EIP editing office hour meeting number 40 this is issue 342 at ethereum caters EIP IP GitHub repository uh on agenda we have few proposals for editus reviews and I see Sam on the call welcome Sam thank you for joining and over to you all right so let's get started with this moving to final sure okay everything looks good there yeah okay the network
consist features optimization while let's start with the title and stuff so for client enr entry okay let's see if there's any discussions going on okay so that's good let's CL off he Network Str client software should be concise
for your spaces representative of client application yeah that looks good let's go move that one to final okay so there was this concern by the author uh that jaal label bot has failed oh that's F perfect good congratulations to
all moving to review 6110 okay pens validated deposits the ethereum okay so why does that depend on this I mean it's it's a good thing to maybe discuss this and make sure that 6110 is
required there or not but I think this is one of those cases those are hanging here and maybe we are waiting on more than editorial review this comment from uh gajender here seems to be more technical review comment than than the editorial so we can uh like for proposals which are into draft especially which are moving for the first time to the draft we can perhaps move these comment to FM and merge the proposals but for this one totally your yeah this one I'm just trying to figure out why it's being required um Fork block deposit okay
7685 deposit request yeah there's new 611 okay so that's why so they're depending on it because of yeah okay that's fine so this one needs to be moved first
so 6110 is draft so presumably there's going to be a PR to 6110 it should be review isn't it because uh all the proposals for Petra has already been moved to review and 6110 is in pectra that's in review okay yeah so it's just an old validated result then MH get that to rerun there okay so forward compatible consensus St structure Okay C defense stable container okay simp Ser container
St container okay we give to data structure for agnostic stable container type B is introduced okay to guarante for must only be appended let not change just a bit l
okay bunch of that stuff staple container okay [Music] okay okay consensus St definitions support okay on field yeah I think this is fine so as
long as the check are looking good out of curiosity like in The Proposal do you see the significant usage of these other proposals which are listed as requires I only checked the first one but let's check some of the other ones here yeah because my understanding is um uh this this proposal will be proposed for an upgrade after Petra and maybe because of that the author has listed all the Petra eips here no they're they're listing um so like they Define the the the CL like the structures that need to be serialized and they have the fields from those eips in them so this one has to come after
those ones yeah I think that makes sense MH okay um in that case inclusion in required section is not bad it is the right thing to do I think so CU like you won't be able to understand what those fields do without yeah okay yeah so this should merge excellent all right um lock will extension for 1155 good
okay wait why is this being added in review This I Swear I've seen this one before um maybe my bad I think I added it at the wrong place it has to be moved into draft yeah no I just I think I've seen this one before um lock oh oh it's probably for 721 uh yeah I think it is misplaced here it should be in the draft section it called it was uh lock yeah okay so this
is the one that I remember reading similar headers yeah yeah okay interface enabling y lock extension for introduces robust locking mechanism for specific nonp punchable tokens within the the tokens owner can lock it setting up and Locker address ex power yep enabling ability to lock the token while address holds
approval okay good blah blah May implement the CP to propose yeah okay may lock Yep this is basically the exact same as the other one so I really don't think think this is going to be a problem to approve see do you remember the number of the other one most likely they
are6 they are yeah yeah same author yeah yep cc0 CC Z yeah this is definitely somebody who's gone through this before yeah maybe the same yeah yeah exactly so that shouldn't be a problem and then let's move on to I think we skipped uh no did we yeah yeah yeah that's that's the one yeah okay
okay let's give this a read okay so let's start with the first thing btics for inline code okay good okay defici and motivation
section so those are moved I saw that was moved into the specification section perfect segment on line 52 which is yeah so that's gone 54 okay so that was okay yeah so it's still the same same
kind of thing here so uh get properties
they Define removed somewhere else okay just get properties do when given a token with removed prop yeah I think that's a reasonable comment okay um 127 you really standing okay see okay so let's find 127 so that's just deleted
burned or has no property shed okay so I guess that is specified there okay so I don't need that okay so I think that's all of okay 139 an update function so 139 okay so it's just removed yeah so I think we're good to merge this then yeah okay so let's take a look at AB specification for revert reason string it's firstly described
here I think it's just a case of adding a new author okay so added the author so I think we are good to merge this to ex gu specification we have the new author perfect the interest of doing this quickly we will add
that and then where is it here there it is so rational comes after specification ration specification okay so we'll do
that we will refresh this the bot should stop complaining and it should be good to merge what's failing in this spot anyways weird okay we're good so let us approve this one [Music] and yeah I think we missed one review
yep okay okay so this going to review contract BK okay diagram oh yeah they don't actually Define an
interface in this one I token the cash CLS okay that's good P associated with the IRS must be tokenized by assuring tokens to the respective parties okay cool flexibility okay that's good that compatible with the ec20 reference mation good that all seems fine so we'll just Comm
that and then I think we are good to approve this one all right so backwards compatible postquantum migration all right so okay the power Quest so let's see
all right for there's one in here doesn't look like it
okay implementation standard can okay so did I comment on some of the stuff before and they just ignored it no Okay so okay they actually site things that's
awesome okay so we can so what is this this is quantum Resistance 2 Computing yeah here okay okay okay
so okay to bring Quantum resistance to ethereums this is let's see if we can make that a little bit more specific because that's important here we need to say okay now backwards compatible approach let's say um okay then this is okay without require iMed update to existing looks like we have lost
Sam I hope he'll be back soon how's that way better you're back yes thank you sorry about that okay so we need to go back to tightening up this description here so uh so may you want to screen share oh yes I am so sorry I am very much not used to my computer dying halfway through a meeting all how's that working well
okay um um no backwards compatible approach okay so
let's say uh key gener proof knowledge to ensure that security transactions canot be by computer the digital setting system is to be updated as follows okay signature now compris of digital signing proof generation okay sign verification okay so key generation
okay resistant okay so proof generation adding a z quum resistant [Music] okay okay proof okay so by proof knowled to each signature
okay so otherwise I think this looks fine it's just the uh yeah and anyway it is a draft proposal so it's good that we merge it so we can take further conversation on FM I don't think we can merge this because they they say that they have a patent and they aren't willing to license that patent so it's like we we can't really have a proposal with a patent that they AR willing to let people use yep no I got it yeah how is it in in EIP section is it this one
yeah I mean I'm just wondering like are they trying to propose any changes to the main net yeah they're they're suggesting that um they add a set like a new field to um uh where did I see that here generation yeah all right yep got it yeah complicated one and I'm sure if it will come any time for consideration going to be creating a lot of conflicts yeah yeah yep yeah I understand it cannot be moisted as
yet yeah so I'll create I think we're probably not moving ahead with this one let's see yeah I think it's getting toward what stagnant status or what like not been active for quite some time no it should be new yes I think I did review this one they just need to update it so we can skip over that so oh no worries evm transaction bundles okay
good and yeah let's give this a read okay yeah meta transactions to order other transactions without Riv protections okay that's that's good so this CP introduces two new 20178 transaction types and one new OP smart contracts and transaction delate the local sequ and ranks to an offchain
entity bundles which are similar too but weaker than the propos or Builder separation bundles offered by Builders to say okay one of the okay specifying yep submit a transaction just not transactions own typeing new type yeah that's great okay currently a single block Builder has uned control over the final sequence of a blocks transactions the supposed PR of [Music] sequencing signific value flow more parties participate in the construction of single blocks okay just addit this go down here here put
in okay that should still work yeah okay commit those okay two new transaction Ty delegated typ ble the should be interpreted as great the signature y elements signature over y the bundle type should be interpreted as sure transaction list element okay per okay good it's fine gas fair low for delicated TX type
okay cool okay those are all actually rationale good I think this is good to move merge okay okay deactivate VIP 158 I think gam talked about this proposal um in the last meeting and yeah it is ongoing conversation so
okay okay so we have that for okay
[Music] so deactivate okay going to move it to withdrawn okay so I think they're going to move this to withdrawn from what I have read here oh they want to put it in as withdrawn there is no need to be withdrawn if this is not an EIP merge asn't draft right yeah yeah we can simply close this one and maybe reallocate the number to someone else because this hasn't been merged yeah mhm
um yeah okay all right grant permissions from wallets okay 107 hidden items love to see it
what's going on technical comments okay lot of technical comments this uh yeah I mean this is not a good place to keep all these comments no it's not permissions from wallet to find a new jonc method wallet Grant permissions so this is a standard track erz sure for to request a wallet to okay we Define a
new Json RPC method wallet Grant permissions for dap to request a wallet to Grant permissions that's kind of awkward so for okay T can
request executing transactions for us without a wallet connection executing transactions for uses with connection that scoped with permissions um okay okay okay hi
hello hello hello hi how's it going what good just curious do you have any yeah do you have any specific proposal that you want us to be reviewed yeah yeah we've been working on EIP for a little while and we're ready to uh submit actually and I wondered if I could uh show you on my screen a bit and just get a bit of feedback about um the last stes before I sub and about how the number was very well um maybe after the review of this proposal you can share the link
here and then um you can share your questions uh share the screen talk about your questions that you may have before making the request yeah okay thank you so much happy to um yeah jump in when you're finishing this referal yeah go for it thank you just let me know when it's a good one oh you can go for it mine right now I think we are done with the last one yes okay I will just get ready to share my screen one second here I hope the screen sharing permission
works for you right yes the problem is I I have to go to my computer and I need to get this link for the call which I'm struggling to get like to rejoin okay no worries in that case you can drop a mage message whenever you are ready and we can perhaps go ahead with reviewing rest of the proposal sir sure um the the 30second overview for that is um when you have something written down feel free to open a poll request um the number will get assigned uh like to your PO request and uh that's generally the first step
so uh let's look at common quote Oracle all right minimum stand for or value feeds D sorry to interrupt you may have to bring up your screen NOP you are right there we go okay I don't know why people like minimal standards so much like everybody writes these these things like minimal standards is like the way to go I don't know why and per fixed people
uh are very impatient there's so many of these things to review okay so come and quote Oracle interface for data feeds providing the relative value of Assets in the ethereum and so we can remove this um okay the following state allows for the implementation of a St that's the implementation
of Fe providing the relative value of assets and EV okay so for okay the information required to Value
ass is over major minor integration API and security further on use this complexity from the coration much duplicated effort the specification y That's good okay base assets is the asset that the user needs to know the value of the quote asset is know the base I need to know the value of yeah okay good Bas okay okay Returns the value of Okay so get quote must run down toward zero must
revert with over supported here if not keep okay all right special addresses so 7528 7528 good okay can we actually get to [Music]
okay okay so yeah right we cannot access them directly yep errors
okay okay good yeah that's reasonable all right did you get your screen sharing worked out yeah I did perfect group the link is it all right to SH now yes please go ahead thank you okay I think the screen share doesn't
work but I did send the link I'm not sure why it's not working but I sent the link in the chat maybe we could look at it directly on the Google do yeah I mean either Sam you can pull it up or I can do it oh thank you yeah that would be great thank you Sam and I'm also just sharing another link here as uh this this idea that e have been talking to like a core community and people working in AI around the ethereum ecosystem and we're hosting a Research
Forum uh during UTC in a couple of days so just share the link also for some context with my my questions um yeah so basically we we started working on this uh a few months back earlier this year and we're looking at bringing a um a context file to an erc20 to enable more intelligent sharing um for uh bringing more AI into ethereum and yeah one of the main things that I'm looking at is just double checking I got all the things to make it ready in terms of the um requirements to get the EIP number and I'm wondering how long that takes to get the number you
should is it like a matter of days or how does that work back yeah so once you open your PO request um it should be assigned within I think it takes at most like a week um the the person who does that usually pretty on top of it um so it looks like uh just just judging from the simple summary here it looks like you're you're basing this off of an older template uh for eips so I will put the most recent template um well this will always be the template but put that in the chat yeah so when no this is um this would have
been oh six month I guess oh yeah longer than that I think I think it's um 3 years something like that yeah okay okay thank you for that wor L that um is there any case where it might be less than a week or is that very uncommon like if you need a number right away I could just assign one as soon as you um put up your Port request yeah oh that would be awesome yeah because we would love to get this discussed at the Research Forum because we have a lot of people who have been part of the CIP and like discussing it in the implications of it so we'd really love to have a number um for our
research day on yeah yeah I can I can do that as soon as you put up the PO request then oh awesome thank you and is there a way to be in touch with you directly time about that uh yeah um I have Discord and telegram I can put those in uh in the chat aesome yeah thank you um one minor thing that I'm not seeing here in the file that you have shared is the link to the fellowship of ethereum magician you can open uh the discussion thread over there because that link would be required uh for the pull request that you would be making to get the EIP number or ERC number you wouldn't be getting it without that link without the Forum discussion link right yeah exactly yes
got it okay that's very helpful thank you um yeah do you see any other things that are immediately obvious between the template that we were using and the template that's new we'll definitely check it thoroughly but just if you see some like things that change this uh so when you open the po request there's a bot that'll go through and and tell you most of the problems with it um that that's the easiest way to get most of it done but uh let's see can read this to compute veilance points okay there is RFC 2119 I'm not sure if that would be allowed to get in there uh rfc's are allowed um you just have to there's a
specific way you have to link to them but uh that's an EIP 1 if uh yeah like go yeah so as long as you link to them in this way um you're allowed linking to rfc's okay so okay trans okay okay and meline once your proposal is moved into draft and you are ready with the reviews collected want to move it to
Future statuses this is the best place the meeting that happens every other two weeks uh EIP editing office hour you can add your poll request for review and that would be considered for the meeting thank you my calendar thank you so much okay so for this particular paper uh just like this dock uh thing you'll have to reference it using a different way of referencing things which is also in EIP 1 uh and you'll have to reference it using this format and I can probably
quickly do that is there a way to get the [Music] citations no no okay yeah okay you're going to take to the same place so um don't want the whole thing just give me the link there we go okay we can take
this plug this into this and then we want you in CSL Json which is going to look like this so I don't know where you would like me to send this but um you will need this blob of Jason to be able to site this paper um all right new want value the trans maybe here in the chat Sam would it work uh I can paste it I don't yeah I know entation would be going off but
okay um [Music] mine I don't know if you are already on the uh e caters Discord Channel but there we have editor EIP editors Channel where you can post your questions even before and after the meeting you would find all the editors over there oh thank you yeah I'm in there um to get this joining link really really appreciate sure either of you um in Brussels by the way sorry the of in Brussels no
yeah um if there's anyone in the community that you know is uh is here for EC that might find this interesting um the Research Forum we'd like to welcome them so I don't know I can post a bit maybe in the Discord just in case you we' love to welcome people so this is um kind of a common thing we see with with proposals where um instead of talking about uh what the implementation is supposed to do you're you're talking about what the the standard is going to be doing um so try to avoid doing that and and uh talk more about how implementations should be done
um like because right like you're saying the proposal shall Define standard interfaces just Define the standard interfaces um yeah okay okay I have to ask did you use um AI to help write this I'm just curious yeah a little bit like taking the template of how it was done for others to help us like structure it yeah yeah I've noticed that it hasn't updated to the latest stuff
so uh yeah okay so welcomes okay so for your test cases I would try to make them more specific um like if you can actually specify like a set of transaction inputs and and what the outputs are supposed to be that would be better um let's see outcomes okay so reference so that sorry oh no worries so um for your test cases here um we generally want them to be like uh almost like ready for a computer to execute so if you can Define say the
input as a transaction that you would send and then what you would expect the changes to be after the trans action um so that is just more more formally verifiable I guess as opposed to English descriptions um would would be better um yeah then for your reference implementation uh if you make it MIT you'll have to do it in a separate file if you do it as cc0 you can do it in this file um or you can just remove this line that's up to you um but again this will this will be a lot easier to review on the ual po request um but yeah I think this is generally pretty good I think uh you're going to need to go a
little bit more into detail about the implementation uh like your standard is a bit too high level but you know I think this is really good and it's a good starting place this is so helpful I really appreciate it thank you so much no problem all right I got to go to another call so uh I will talk to you all in two weeks thank you Sam thank you everyone for joining us today thanks I'll send you a message we do up here as well thank sounds good see you thank you