EIP Editing Office Hour #29

Transcript

welcome to EIP editing office hour meeting 29 uh this is issue number 298 on EIP GitHub repository we are joined by Sam Wilson and author of a proposal so Sam if you would like to maybe share your screen so we can take a look at as you go reviewing proposals sure thing so where are we off to First Francisco if you can mention your PO request number perhaps we will take a look at that yeah it's the you see the number 30 the one is yeah oh no no no this is another proposal that is oh no

no is the one after one two yeah because the only change that comes during the last call is that someone was saying that the comments in the in the interface were not clear enough so basically I I improveed the the comment to try to make more clear how to use the sure that's the basically the change that I did in this PR this was only that okay must be the

just yeah okay so it's just clear a few things just [Music] little but one thing that is weird is that in theory I should have been able to merge the pr since it was already a little change he said for some reason it didn't allow me to to do it I don't know why yeah I'm assuming this is because it's in last call and when you change something not like trivial um you're supposed to restart the last call deadline but like this seems very

trivial I have no problem merging this so yeah cuz you're not changing the the actual content of the EIP at all you're just changing a little bit of I change yeah I just changed the the comment of the the interface in the I think I change it in the description and in the reference implementation that is it yeah no that that seems fine to me I think like I said I think it's just because um the the restarting the last call period we added a rule a couple months ago about that so um yeah I'm assuming your interface ID is correct um yes I

added also there was a missing test for that and I added you see perfect so just to verify that is was correct yeah no that's that's great let's just make sure it merges and then yeah so this should merge cool very well uh for people who are following this call we have also planned a peep and EP meeting for ES 6982 efficient default lockable tokens so if you guys have any question uh please join us on December 28th at 18:30 UTC and yes Sam we can go ahead with a

couple of other final proposals listed here on the agenda today sure sounds good okay so that looks good let's take a look at the uh discussions too make sure no one's talking about anything yeah okay and good that one merged incorporates locking features into ND for various uses

good yeah so I don't think anything's changed so we will go ahead and let that go to final and 3643 going to final nothing important here okay it's the T-Rex token nothing snuck in here that shouldn't be here good transfer

okay interfaces good good that all looks fine and then let's just make sure there's no discussion going on so this is my discussion the the okay okay okay cool yeah so they they have

justification for that so I am satisfied so let us go to final I think this is very good practice that we are trying to have minimal changes included when moving from last call to final yeah yeah gets really difficult to review if you have to like compare everything and yeah so let's see got some last call things here I have a question yeah since in the 6982 was listed in the move to final but my PR I was locked with the previous so I didn't make a PR to Move It from

last SC to final you know the pr was just a change in the comment uh which is the best way to go now I make another PR to move it to final or yeah yeah then chose the I can do that today if you want to throw that up okay if you okay yeah perfect thank you no problem all right this is moving to last call can I edit this I can excellent so

26 oh I hate when interface IDs change why did that change so that changed but the reference implementation didn't change does it not have a yeah okay all right let's see if there's any act discussion I doubt there is we might as well check yeah

okay good that's merged okay the standard exens ofc 721 Define standard functions that's good piece of paper okay yep that all looks

fine then there's reference implementation cool yeah I mean nice we have another last call this was is a IP yeah it is just for like um documenting the network upgrade activation trigger oh right right right yeah I just had one comment here like should we move it to last call or should we keep it living because it seems like it will continue documenting changes post

merge um yeah it's I think this is just a list of all proof of work upgrades um until uh the proof of stake trigger and uh it also includes post merge upgrades up till Shanghai okay yeah I think this is fine going to final um I don't think it's going to list yeah it's just saying following a

pattern um and then it uses time stamps um yeah I mean I'll leave a comment in the PR but um as long as like Tim's aware that this is going to be uneditable I think it'll be fine yeah that that's what my comment is as well like if we find it it's not going to be Ed editable because this is an informational EIP it makes sense to provide and keep adding information but yes

for cool okay so now we have some T review we don't need that open anymore okay so minimum specification for managing multiple tokens by their ID in a single contract okay

okay we'll do that calls required B and transfers okay the maximum value Balance 5 okay the transfer event good good good interface D that shouldn't be in rationale

okay metadata extension right so okay

um okay so is not backwards compatible that's fine security consideration good copyrights there so this requires comments okay and 6224 all right

okay can I Ed this I can right syst smart contracts decentralized CH dependencies so okay for growing eum ecosystem projects tend to become more and more complex prot portability clear architectural facade okay neat um so

okay sending of okay to cont contracts there's a diagram contract contract blah okay good some comments I like comments good okay we have dependent

okay the contracts identifier okay that seems fine inject good reference implementation nice dependent okay all right so we'll just leave those as comments we won't approve yet since it's going into review okay token Revenue

sharing okay to every token is a token that shares rewards for holders um okay so it seems like this proposal is here for the first time yet they have added the status review oh yeah yeah that's true 7 well 7254 that's that's an old number um Okay can where's that coming

from yeah it's there sorry my bad yeah but the way it was drafted I did not see the status change moving from draft to what's going on here is it because of the migrating ah no it's it's it has the wrong file name okay that would be why um okay

then okay so I can't really review this until that gets changed all right 7254 and then we got this one so I suppose another PR was merged to have this change Incorporated so I was wondering if we can simply close

this oh um PR number 8009 is the other one which is requesting the same thing but with the changes that you have recommended here in comment yeah so there's there's no changes in this now

so um okay 7569 to review all

right so this is the mat that is coming oh okay so the idea was like because this is matpe we would want to bring it to like status of the upgrade so sooner the better is the idea yeah okay I mean this is this is fine I'm not entirely sure I like these kind of VIPs but yeah

okay what function call Api add some stuff yeah can't do that is okay yeah no I was looking at the no I think I'm looking at the same one so okay got it yeah I was just wondering like why this is stuck here got it yeah yeah m

okay yeah so this you just need to and then some Moody approved so [Music] so okay good I might have to drop off a little bit early today um actually I definitely will have to drop off a little bit early

today uh so what's going on with this one so here I don't understand why is it not merging it looks like everything is good but and also approved there's been a bunch of these um there's there's just something something wrong and I don't know what it is so I listed two of them in miscellaneous PR because it seems like they are fine but they are still not able to be merged so in that case may I request you to look into ERC 105 uh that's an account abstraction uh proposal and author requested that to be reviewed okay yeah by the way I made a new P request to move to final so if you want to that was on erc's yeah it's the number

158 sure just that one 158 move to final and uh you're all good to to never edit this again it's all correct you know because the the only conversation that I had recently with a friend he was saying but maybe the event would be better if it's called lock and theault lock instead the locked theault locked but I may agree with that but the problem is that it has the the interface has already been implemented in many projects yeah okay so I would break the

projects I think it is it's not worth to to think to change that yeah okay yeah as long as you're happy with it I'm happy with it so we can move this to final there and then we can go through now where it go 105 okay cration okay sub liation validation okay do describes the validation rules we impose I'm going switch this back to unified

account forceed off Chain by block Builder or Standalone Builder Okay um possible set of actions just considered to be a Mass invalidation Attack of the network have large number of user operations did pass yep okay three ways to perform such an attack us your operation us your operation and isolation yep yep good okay yeah I'll be right there to help with um yeah uh minut sake delay good wait why are these are these in okay those are in specification that's good okay

validation rules this not was calculated as okay okay good up code rules okay

okay St RS entities specific rules okay good I just see a men of

4337 uh somewhere in the abstract I know it will be fine for now but going forward it would be a problem so we might want to warn the author here yeah it's a good idea okay

okay transactions okay by on okay yeah so okay

good yeah that's good um okay for

okay um what else um for

all right cool I have to go give my rabbit some medicine he really doesn't want to have so I will talk to you all later thank you Sam you have a good rest of the day have a good day bye bye bye