EIP Editing Office Hour #28

Transcript

welcome to EIP editing office hour meeting 28 this is issue number 296 I have shared the link in chat um we are joined by Sam Wilson the editor who may be answering questions for people who have joined here with any kind of query thank you all authors to join us here so we can start with the first uh PR added for the final Sam if you would like to maybe go ahead and screen share and we all can be looking at your screen while you will be reviewing the proposals sure can

do so you want to start with 7160 yeah right okay yeah right so let's just give this a quick look over and then it should be good to go 721 multia data y that looks good okay

yeah that all looks fine then let's just check to see that there's no active discussion let's see yeah this seems reasonably complete all right we're good to approve all right and then 7201

okay I think I went through this one last time and it was good just going to give it a quick look over oh yeah yeah this one's this one's fine I remember this one all right so Sam I think we are joined by an author of um yeah 7219 he has some questions with respect to his his EIP but not specific to anle request so Wong if you would like to maybe reiterate your question

here uh hi uh thanks pja uh so Hi Sam hey so previously uh for my EIP 7291 uh there was some review by like client he requested for some changes so after that we have made the changes and updated the pool request but uh after that there wasn't any uh update or further review for a couple of months so just wanted to find out whether there's anything that we need to do in order for it to be move forward uh no it's probably just waiting for somebody to take a look at it um which one did you say it was uh

7291 uh EIP or ERC uh previously EIP but I recently move it to the new ERC uh I think it's 128 though Erp erc1 128 yeah this one okay that's right yeah so it's just that people haven't had the time to look at it yet I can take a quick look at it now uh interface extending your C 11 to implement purp spend money Hy form progr okay good and the outline this propos outlines the SM contract interface that builds upon the

er55 standard to implement the purpose bound money concept the purpose bound money is comprised of a PBM wrapper and a digital money token that wraps a digital money token Services histor value abbreviate so dig money token okay okay yeah that looks good so the EST of this proposal SE for technology fragmentation cont by making PBM specification open it gives

new participants easy free access to pre-existing Market standards okay this cost participants okay uh no I think I think that's fine actually okay okay digital

[Music] currency okay okay so this is this is a long one so I will probably take this one offline and

then um I'll finish up my review later today um but yeah so far it looks pretty good I think um nothing immediately jumps out as as hugely incorrect let me just take a quick look at your um rationale here yes so I think yeah I think you're you're generally good I'll finish this up today and then um hopefully we we can get this merged so thank you Sam um I think we are now joined by author for two new drafts uh PR number are 26 and 27 on ERC thanks thanks Pua hey Sam uh nice to

nice to connect I think you've reviewed in the prior when when the eips repository you had a more extensive review which I um uh addressed everything so uh just curious if there's anything further I could do sure I'll uh I'll take a look thank you okay yeah yeah I looked at this one yesterday I think yeah yeah you did just yeah as yeah you move that one little paragraph So I think everything else looks fine for this um nice thank you so much and then

there's there's the redeemables one as well it's the next PR number so 27 27 it uses is the dynamic traits um so although yeah I did link to the dynamic traits EIP or ERC but it wasn't because it wasn't merged now that it is you can see online 25 I just have to like change that space so it CI wasn't complaining so I could do that now or if you want to merge it I could just do an update afterward or like if you approve it I can do update afterwards whatever you prefer I could just do it right now for you for you oh thanks and yeah I'll just uh I can accept it there might be a couple other spots if you just want to

search like that e do that apprciate it so this pr25 that also is uh an EIP by you because I see that is also added for today's agenda um no what's what's 30 that was not shouldn't be 25 oh sorry Peter land okay okay Peter we'll take it after this one [Music]

sure there we go okay okay so this proposal introduces a new interface that extends 721 Discovery

okay okay creat use nfts to create redeemable entitlements for digal physical guids however without a standard interface is yep that makes sense um by functionality for Discovery onchain offchain okay yep that makes

sense okay offer consideration above so what is offer and consideration above that's in the yeah the struct campaign requirements um uh we're using the same terminology from Cort which is the offer is what you're offering consideration what you're getting back so that's the same for this uh time Redemption campaign okay sense mhm I could probably expand on that if needed oh no no it's fine I just want to make sure that you're not just putting random structs here that aren't used in a function yeah okay we're good getting

new campaign okay for

for yeah just um just because like some people might increment it before or after um doing the assignment so I think it might be more clear to make it uh explicit that the first campaign must have an idea of one yeah that's good feedback thank you to campaigns was use update campaign if that makes sense um so this is implying to that there's no other way to update a campaign like you have to call update campaign to to change it is that a correct interpretation um yeah but maybe that's overly prescriptive I think it's more so

must admit the campaign updated event so um yeah it probably doesn't matter [Music] okay the tokens are set in the PRS oper the

tokens okay nice got some Jason schema in there

that's good back ability good yeah that looks great um yep good R now yeah that's great um yeah I don't think any of these are going to block merging this as draft um so we're going to go ahead and approve that just make sure to fix those before you go to the next stage okay yeah

definitely thank you so much um I think on 26 the one you just approved the uh trigger failed I can't rerun it I think it was waiting for the HML appr Maybe an ordering thing it will do that you can uh usually close and reopen your um P request to get it to rerun um okay I didn't just yeah just in case like yeah I might have to do that on the uh on the next one just once this one's actually in but uh cool this good to know get this to work yeah so um if it still doesn't work just

uh well I'll I'll keep it open and I'll come back to it uh all right we can take the next one here joined by Author Peter and the number is 25 25 thanks again Sam that was great problem it all right so why isn't this merging oh is this a this is a new EIP all right actually actually not it was put a stagnant I think we put um it was opened last year setus draft december22

and then it moved to stagnant and now we made some changes on the interface specification and yeah basically no perfect yeah I think this is probably going to be okay I'll just give it a quick read um good yeah we made it a little bit more generic so this is why we change a lot of the

description more General is often good yes I think you can use um solidity for these it's not like going to block um okay good r now okay got that yeah yeah sorry

sure but everything else I think looks great impation your licenses are all open source presumably yeah sure yeah yeah this looks fun it's just um just that one comment I can even do it uh if you want I can't do it so yeah just uh make the change and then it should be good to to merge okay all right so all right the next PR number here is 38 and we are joined by

David Hi Sam hi folks yeah great here um yeah hope hope it's the same for you Sam you've had a look at my PR about two weeks ago um you've raised four questions um me and my coauthors have since um address that the uh the questions that you've raised I'm just wondering um if you have any other further questions for us uh probably not I think this is good I'll just give it a quick read and then yeah Che thank you

think the biggest change since you've last looked at it um is actually the inclusion of an example that we' we've included from one of the artwork um pre one the The Great Wave of um Kagawa so we' we've actually provided an example um like you asked oh perfect thank you okay good and

then ah okay so I think um so is this is this actually also valid 721 metadata or yeah okay I think it is I'm not super familiar with 72 yeah okay then that's that's it's sort of a super set of it um we've included an attributes um attribute from from open SE just to stay compatible with the marketpl out there yeah that's perfect then that looks great thank you so much and then you still have the yeah okay good good back

compatibility yeah that looks great awesome and then hopefully that'll merge on its own all right so maybe thank you Sam appreciate your time yeah thanks for coming out maybe we can go back to the last call that is PR number 7984 all

right moving to last [Music] call so what is two weeks from today that be the 5th is the 12th okay yeah okay and I would assume that this is good memory

copying Novation all okay so that's easy

enough uh to review hey I can't review this everybody's favorite no I think it's just coming out of a stagnant I don't see much changes it's just that to move it back to the review yeah I think it's just uh maybe a link issue what's going on here yeah I since this is my own EIP I'll just leave that for lat um all right so 7516 yeah so same

problem so for 3074 do you want me to add it for tomorrow's meeting no no it's it's just hung up on a a bug in the build system it's not uh okay yeah same same with this one actually there's nothing actually wrong with it let me guess the same problem yep 5664 are we expecting it to be resolved

by s or do we need help of anybody here uh I think it's just um they need to update the branch which I can't do because I don't have permission um so I'll just leave a note on the uh the poal request [Music] okay yeah that looks

fine okay 7439 okay so this is the ticket toing one I think I reviewed this one yesterday so so they changed anything major they should be good to go into review Sam I think Ryan mentioned that

there is some issue with the pr26 as well if you would like to maybe take a look6 sure yeah just the open close didn't seem to I don't know what's the H um auto review bot trigger is failing on the stop bot recursion I don't yeah I have no idea what that is that's weird yeah yeah it's a PR um 26 26 in ercs you yeah okay I'll have to yeah if you open it just it's weird this first step yeah no I know I'll um talk to Panda pip about this it's

unfortunately outside my area expertise all right uh I think the next one requested here by an author is bofu and the number is uh 80 80 h z all right and hello hello yes and so thanks for and and the your uh recommendation last time is to update the example in

the EIP to make them become a more complete example instead of just part of the content so basically this updates is focusing on make the three examples complete perfect thank you yeah okay yeah I remember this one this was like where you had example of just what your metadata would look like but not what it would look like integrated into a token yeah uh yeah perfect cont y yeah that's great thank you so much

that makes it a lot more clear I think and then 753 good yeah this looks great okay cool thank you yeah thanks for coming out sorry it's been a a long wait yeah no worries thank you so much all right the next one here is a miscellaneous PR I don't know if it is the right place to discuss this one it's about adding uh G11 Tech gajendra sing to the ERC editor section do we need to just merge or does it need any kind of yeah no this is just merging so uh we had the call for input about adding uh

G1 Tech and uh zenen LV as um full editors and now that they're full editors they can review whatever they want so perfect let's add that so the next one is a pr42 which is about fixed links in erc's markdown I think they are trying to update the yes I think this is going in the wrong direction um yeah so it's going yeah so we can't merge this one because um this will break the tooling so I'm just going to leave this one for now and

uh I think yeah maybe we can notify the propos or why we cannot or if there is anything they need to fix it I think this is more for a tomorrow's call um okay I can add it for tomorrow's agenda 42 yeah thank you um I don't think there's any decision I think we just need to talk yeah yeah just let other people know about it yeah exactly very well uh then I think we have just couple of more left the next number is 21 all right trusted hint register okay

okay we should remove the sentence that this should not care about m Open okay good uh think of k1c 55 yep that makes sense the for

cool and then yeah I think we're just waiting on them to make some right yeah okay good so they just need to update we have just one last perfect um e this say what is this okay this is an actual EIP all right from Forum restri the size of the chain ID parameter to a particular maximum value

okay yeah so this is moving it back from stagnant to draft sure I have to approve it again or is it's just going to work okay good yeah so is that uh that's everything for today wow okay yeah that's that pretty much covers everything for today I have a couple of more questions for you some like I know

we are going into a lot of changes many people have a lot of questions with respect to what to see in the future I have uh like informed people that there would be decision taken on EAP meeting so perhaps we'll get some more participants in tomorrow's meeting but specific to this EIP editing office our meeting um do we see in future that we would be including right now we are including ERC and EIP but do we see in future we could also be including rip Rel proposals how do we want to go about it like mostly we see erc's here only uh yeah I mean if rips um you know be like go down the road of becoming eips which you know I think would be a good idea um

then yeah I'd be perfectly happy to review them here or at least to have uh RP editors come on and um and and review them um I think that's a great idea but again that all really depends on you know whether they become eips or not or or whatever that yeah I think uh that is in the line of that because we have recently created this repository like it is github.com ethereum rips just similar to eips and ercs and as of now we do not have any RP specific uh editors we are hoping only uh EIP editors may be able to support that U we'll perhaps have some more discussion tomorrow meeting uh but yeah I I was just generally curious

like should we make this office our editing office our generic for all sort of eips coming to ethereum repository yeah I think that's I'd be willing to do that I think that'd be a good idea um yeah like um probably uh bit of a project I've been working on um and uh this might be a good platform to talk a little bit about it uh so I've been working on uh EIP working groups and I have a little bit of a demo of um what that might look like uh you can play around with it on eips F Yi um the big difference for this is that each one of these projects is now in their own repository um otherwise it's basically the same as as today um and this is kind

of the framework that we'd use for adding our IPS again if if the other EIP editors are on board with this this isn't like a sure thing yet um but you know if they are uh then you'll probably see a new little tab up here for Layer Two and uh yeah that's where our IPS would live um mostly just technical backend changes um there's not really that much different for EIP or ERC editors you just have to make your P request against a different repository um yeah so uh if anybody looks at this and it's like that's a terrible idea or that's a great idea I'd love to hear about it um otherwise yeah um that's about it on

this kind of project I've been working on sure I mean I'm hoping that we will perhaps get a uh summary on tomorrow's call as well for brigh uh for broader audiences to learn more about the working group concept I have also shared the link with respect to the recording that we made on a peep and conversation uh about a working group and how it may look like if people would like to learn more about it but yeah looking forward to have this conversation with editors and see where we are going thank you sir yeah thank you all right thank you everyone for joining us today that's it for today's u e editing office hour if people have any more questions please

feel free to add it to the um agenda for the next meeting and we hope you get the support you are looking for making your proposal have a great rest of the day everyone thanks folks have a good day ahead