EIP Editing Office Hour #25

Transcript

welcome to EIP editing office our meeting 25 this is issue number 262 at eipip GitHub repository thank you Sam for joining us today and thanks to all authors who have joined so um Sam if you would like maybe we can yeah go ahead with screen sharing sure yeah so let's get into this we have um do we have any authors here today that want me to look at their Eeps they are right so we are joined by uh Stephen Stephen had three proposals for today's and I think one is already merged so let's go ahead with the second the pr number [Music]

this is the one here yeah okay yes this one here is for my team perfect [Music] good I think you've been through this this Rodeo enough times I don't think there's gonna be any problems with your proposal um good test cases yeah this is the second one where we discover a huge Improvement so yeah one yeah this was the uh like multi-character emote problem

yes yeah like after getting to final we discovered like we didn't support we supported only like 40 of the Korean emojis yeah okay this is totally fine uh yeah with the next one we are we we learn our lesson and we're actually uh doing something in production first before trying to move it to final but we think it should move to review now yeah okay that makes sense that was 7409 and did you have a third one or yeah I wanted to move to review uh it's 7508 sure I can take a look at that one here okay any utilities for 721 all right

can we expect a smart contract without the need for the token to be aware of the external smart contract for example represented game character with a set of attributes it can be used in unrelated game with the same stats without the need for treating this attribute from an opportunity Source this ensures that the data the game is using is legitimate not tamper with in order to mean touch okay so is this like a key value store that's like two levels of keys one being like the token and address and then like then a key Value Store per token address yeah the idea is that you can set any yeah any kind of property or attribute

into any existing token but it is the creator of the collection the current owner of the collection who sets which attributes are valid and who gets to update them so it could be only the issuer of the collection or a collaborator they can configure or the token owner or some specific address it's very flexible makes sense and for to store string attributes so for the keys uh when they are strings we we have like an extra mapping where we map uh like the string keys to an ID so we use that ID from then uh for the mappings instead of using a string which

is more more expensive yeah that makes sense so are the um the keys like namespace so if it's set as a string initially can it be updated to a non-string later or uh that's a good question I don't I don't remember right now I think I think you could use both actually okay so you could have the same name for for two different types of

attributes because on both Setters and Getters they Define the type so okay so like the same key with a uint and the state like so if you had like the key a and a u n could have a different value than the key a string that that makes sense okay okay okay pre-signed attributes so this looks like 7 12.

is that yeah that this has to be 712. let's call it you call it the pre-signed yeah I think we should include it definitely

yeah because it looks like um 712 but it doesn't explicitly say 712. yep um good yeah otherwise I think it seems great it's perfect great thank you Sam cool so the next one is um two proposals actually uh they are six eight zero eight and six eight zero nine they both are merged to last call and here Arthur is Nick he had some

questions for you sure of course yeah so the speed at which we emerged was fast and anticipated um um with the pull request uh before the deadline how much sooner can we actually merge into final uh so when you set your last so sorry you uh which PR did I just merge for you um it was six io7685 and seven six eight six all right for ERC or eip6808 and yeah so um

anytime after your last call deadline you'll be able to open up or request to move it into final okay yep um make sure that there are no changes left that you want to make because once it goes final there's there's no no editing it all right okay thank you no no problem next we are joined By Conrad and the pr number is 7484 4 all right did you have any particular questions hey um no I didn't have any particular questions actually I was just wondering if you could take a look at

um kind of yeah kind of merging the initial initial draft basically yeah sure let's take a look where's Mark oh So based on the description in your abstract this is like a like an auditor can vouch for a particular smart contract and say you know I believe this is secure and then another um smart contract can check this registry

when somebody adds a plugin and then determine whether it's secure or not yep yeah exactly kind of more generally it's like an attestation registry so you could also use it for non-security related kind of about the stations but but that's the main use case have you seen the ethereum attestation service yes yeah our code is actually um or our reference implementation is actually um inspired or took a lot of inspiration from the easier specifications yeah nice so um yeah

proposition um actually I had a question on that comment is this true even if kind of we mentioned um 690 as an example of of kind of like one implementation yeah like yeah so okay like for example if you mentioned 6900 and today it's an example of you know a 4337 account or whatever um but you know in in two weeks the author of that EIP could completely change the meaning of it and then your link wouldn't make any sense right so it's just about like you want to kind of move them together to final that makes sense okay that makes sense that makes sense because we didn't uh specify that this EIP requires it

because it's not in the specification um but but that makes sense anyway yeah it's okay first solution security considerations of the market was required certain statements about these security modules and can require chain s create on geneticizations okay on transitions made by the security of module not General okay well that seems fine so and adapters means for a little excellent contracts to Smart accounts to

query the modern virtue before using a module in order to create account must implement the adapter either natively in the account or as a default module this is on the center and account deployment all right choose this okay foreign

so if I put the comments over here it's like not at an editorial related it won't affect getting merged or not um so it's just just my my very poor technical review sounds good we've actually towards the comment we actually got that feedback already and implemented uh I think it should be just above the comment you're looking at now um ah yeah that's what the registry must have heard yeah well then thank you uh just get rid of that okay good

foreign okay so that all looks good so the only other thing

is um this is always like a bit of a subjective kind of concern um so um you don't really need there's no objective answer to this is basically what I'm going to say but uh why does this need to be an EIP so if you were to you know deploy your uh registry somewhere and uh you know tell everybody how to use their published documentation um everybody could read your documentation and like integrate with your adapter so generally eips are meant to coordinate between you know independent people who um

like need to interrupt but for this it seems like everybody would be interrupting with with this one registry so uh in your motivation you should probably set out like some kind of explanation for why this needs to be an EIP and maybe the answer is it needs to be an EIP because you know that's the best way to get visibility for it and that's an okay answer um but that is just something that I'd like to see a little bit more in here is um if there's going to be one registry adapter why does it need to be a standard yep yeah yeah I think that makes sense we actually thought about that quite a lot as well like before kind of uh taking the the step to to make it into the Erp as well and actually I think

like the most straightforward answer is kind of a bit weird in that if the EIP works then there's only a single registry that everyone uses and because of that like the adapter is actually like very straightforward to build but um there could also be a case and this is quite likely even if the IP kind of is there that people build alternative Registries and then the kind of like the use case of the EIP is that even though these Registries kind of like do their own work or kind of like resolve these attestations or whatever in specific ways all of these adapters for the like smart accounts or smart contract wallets are kind of like make all of these existing wallets kind of backwards compatible with the Registries that pop up

um so it's actually kind of weird in the sense that like if it succeeds then there isn't they need to kind of like standardize because there's only a single entity right but actually like without the proposal there might be multiple more entities and then yeah yeah yeah this is a bit weird to explain but but yeah I think that makes sense to to kind of like rethink the motivations and bring that to life Perfect all right

where are we off to next Pooja the next one is uh with the author bofu here and the pr number is 7682 . yes hello hey did you have any particular questions about um ah yes and I saw Lair is a change request from the um Panda pip so he mentioned that we should specify which metadata should be extended then and I also provide a feedback so I so I think I just want to

clarify um I pass a link in the zoom chat and it's a common and I reply um other Pips input so I want to know and should we should we mention the idea in the common creating or should I really narrow down this VIP tooler specifically at Peaks um so that whether it's specific or not is up to you um let me give this a read and I will give you a better answer yeah thank you very much okay

so mining here is not in the blockchain sense of the word mining uh yeah it's more uh AI ml data mining so this I think the idea of this EIP is uh if I'm the content creator so when I um create my digital content then I have some ways to register my prominence the one is I can just register and as the outtrend metadata so let's uh so I can in this case I can Leverage The eip-70 53 and or I can also meet the ownership over the license LP then it will go to the traditional ft an EIP like the 731

over 10 50 55. thank you okay

you said you're supposed to clear mining preferences for digital media content the business units for ERC is foreign 's kind of concern here without giving

like an exact uh like which metadata you're basing off of it's hard to tell where to insert this mining preferences blob um so like in in I think uh where's the metadata Duty so I'm assuming it would just be in this properties array here for 721 right um yes so for 721 and for like uh 1753 okay so because I I think and I I'm not sure it's like like because like uh 731 is

super popular so many uh senders or eips Will based on it so uh um so the idea is um I trying to mention as the first layer of like then the lower layer as possible so that I don't need to mention a lot of all the standard speakers it's not possible and always they will have the new standards coming so I try to make this a proposal as a festival enough as possible so I think that's the idea yeah so like I I do understand why you don't want to tie to a specific um EIP so maybe what you could do here

is just include a few examples of um like in integrating with other so you could be like here's an example of a 721 token that has a mining preference here's an example of 1155. um that might satisfy a panda pep here um if you haven't already maybe you have I'm not sure exactly so let's see okay of course okay accessibility so

foreign okay

relaxation camera it's okay um definition okay yeah so I I I can't really force you to because obviously it's your standard but I would very much recommend finding a different term than than like mining preferences um just just because mining is is a very specific term in Block space but otherwise I think this looks really good um just a few small things and uh it should be good to um yeah and yeah and thank you for the input and for the um

Russian red snail here I want to cancel you is about the adoption so because like I I mentioned in layer is actually with a there are actually there are some ways we can mention how the data be used for the AI ml training so we're trying to refer to many existing centers including the c2p standard so that's why uh so we're trying to Leverage The Extreme standards and trying to summarize the which we think let's continue this one of the best way to mention and the usage of the data

here so it's a it's a it's a kind of rationale or is still like the motivation um so like so the motivation would be um why you want to include AI consent into smart contracts um whereas the ration that would be like why you chose to base it off a particular standard versus a different standard does that kind of clear it up a little bit um yeah so I I think I I um my understanding is that an original is an explain the technical decisions so yes so and for the adoption part I think our decision is we're trying to respect

the existing standards so that's why we do not divide the like some format by ourselves instead we try to extract the existing standard from the existing existing standards yeah so let's in the adoption part so but yeah yes I think yeah reading this again I think adoption seems fine here um oh I see yeah so what is this is this like a standards body or noticed interesting huh

yeah uh yeah listen to described how to inject the metadata into the digital media locally so it's just like um just like every different media format like jpeg PNG levels have different headers yeah so c2pages you can think it's kind of the spec mentioning how to inject the metadata in the content header okay Okay so yeah I would just maybe let me go back over here okay yeah so yeah adoption is is totally

fine to stay in rationale I think um yeah that makes sense okay I think there is a yeah please go ahead I was just gonna say I think I think it's just um it might not have be like moving it that's important it might just be rewording it so that it doesn't sound like you're talking about the whole proposal um and I think that would probably be the best change let me just update my comment here yeah okay

okay cool so I think there is an issue uh that is a 7700 which is related to this uh pull request I wonder if it is by team of tofu and if that is is there a question check um actually I I don't know about this um this issue actually because I I also don't know uh who is the uh Mike h33 yeah there is I think there's a Spam bot that just scarves people's comments yeah yeah sorry about that but actually yeah

actually I really don't know who they are the only thing I know is that I saw a this EIP was posted on the Reddit so I guess it attracts some people from the crypto Community to be here no problem we just wanted to make sure it is a spam and not any member of your team so we can relate it thank you Sam for deleting that yeah I can probably slide that we didn't do any spam Bots oh no we don't we don't think it's you it's just we wanted to make sure they weren't asking a question yeah we're not just try to pick it yeah all right I think there are a bunch of other pull requests those are added in agenda

um I don't see author present on the call but they have requested this to be reviewed in the chat I mean in the comment section of the agenda all right so we have PMP get back to the agenda here all right so just go through these ones here or were there ones in the comments I think there is only one last call let's go review that and then we'll come to the yeah we are sleep requested by matthas let's Call 0927 okay

okay so this probably actually needs to be updated unless that one's also being pull requested let's check that out first so five five six eight okay so 5568 has not been updated yet it's in review okay so this can't move until that is changed

okay five two six nine so the next one requested here is 7535 right what do we got going on here okay so we have somebody adding themselves as an author do we have an author approval we don't this is core okay so this has already been approved by gender so this should merge it just needs

okay so they approved it um okay so let's see everything's passing there good cool neat

and the next one is 7336 okay Universal domain namespace interface allowing for interactive capabilities across multiple registers like ens Ure to facilitate on train registry entry as you change the structured up some

nothing type allowing for interactive capabilities across multiple accounts okay foreign

Ty accounts the necessity for you to find method of data retrieval across variation is apparent s seamless reading data from every branches to another definitely only keychains information is proposed single the plug contract or treat

records from different combinations of Registries such as CNS okay registry we don't care it's a signal contract enables to retrieval okay I don't care foreign foreign

[Music] foreign

foreign okay the circumference implementation neat and then down here you can say all right

so there's interactive across multiple registries right I think I'm probably going to call it for today unless there's anything else that needs to be done so I mean it's fine it's not like we don't have author present here but there are a few miscellaneous PRS which are not a status change but they are just a small changes to existing peers yeah I can go through some of those six two yeah did you see this one's here preventing

circular block finish with initialize in that case I'll probably head out uh thank you for answering the questions and you guys have a great day yeah you too thanks for coming thank you cheers looks like they are just waiting and they are not waiting on any specific review yeah so this is technically waiting on an author review um and it looks like the author does not want it merged so I'm going to say

oh yeah okay actually I see Oren as an author listed for erc6551 and he had made some changes here yeah it's like some spelling

spelling changes right so I mean like uh Jaden Wendell and author yes so yeah I think I'm I'm just gonna prefer to close it and then if they want to reopen it they're welcome to okay all right in that case where we do have couple of more core proposals they also seems to be like small changes but again approved by author I guess so this one needs an approval from axic but um I think gumbo is also the author for that let me see oh no it's only expensive okay I'll let them know I have a call

with the team so I can let them know yeah I can just put a comment down here oh yeah okay so we want that one almost similar

I think it's for the same proposal yeah okay I won't uh make the same comment again okay so the last one here is for chance I think they are just waiting to be merged yeah it looks like uh just need to review from the authors um yeah I'll just ping a panda about this all right so I will take care of that

one when I hear back from Panda all right thank you so much yeah I guess I'll see you all in two weeks