EIP Editing Office Hour #14

Transcript

welcome to EAP editing office hour 14 I have shared agenda and chat we have few proposals for a final last call review and draft status we are joined by a few authors so the number one proposal that is there for discussion here is 6808 that is in draft section he said six eight zero zero eight yeah yeah this one here all right there we go so do you have any particular questions

about this one or oh at uh the butt failing for no reason that's always good babe did you guys have any specific questions about this uh proposal yes um let me take a look here oh can you hear me yeah oh perfect um one question that we have is how should we uh reference sources we have a few sources that we reference in there for example the federal trades commission when we're making one of our points is there preferred way of referencing these

uh yeah so depending on the specifics of it so this is kind of a new thing for us so um previously we didn't allow any kind of external links um so keep one here um has a section on how to link to external resources um if it is something listed in one of these exceptions like for example the only one I can think of that might apply here is uh having a DOI number um then you would cite it using this format here um if it's not listed one of these exceptions you have two options uh the first is remove the reference and the second is follow eip5757 and

um that's how you propose a new uh permissible link to another place that isn't listed here um I know it's a little bit strict that's our policy on external links exist this way because we try to fight against like link rot and things changing out from underneath us um so we do have a fairly strict set of rules about it so the easiest option is obviously to remove the reference but if it's absolutely necessary for your EIP um then eip5757 is probably your best path there okay thank you and in addition to that um what other keywords such as standard should be avoided

uh they're that's mostly just like a stylistic thing um pretty much every ERC has the word standard in it if if we allow it um you can use pretty much whatever you want otherwise it's just that one comes up so much that we put a special rule in for it okay thank you um and then I suppose um with the Fellowship of The ethereum Magicians I know that's a different entity but um well everybody works together um should we also go about renaming um the currents post on there or should we

make a new one um regarding edits uh just keep the same discussion thread like the even if the name the EIP changes it's fine like it's always going to be linked through the discussions too if you're really concerned about it you can raise the issue with the moderator of ethereum magicians but um it's it's not super important that they match it's pretty common that they don't alrighty and then I suppose last question would be um I guess the next step um as this is our first time sure so the process is pretty uh author driven so once this has gone through a review by an editor and we fix all the little like knits that we're gonna find because we always do

um it'll get merged as a draft EIP and then once it is complete so once you feel like you are not going to be making any more significant changes to the proposal um you or any of the authors can open a PR to move it into the review status um and then that's where you're kind of signaling to people who would be implementing your EIP that it's ready for external people to look at it and start trying it out building prototypes uh that kind of thing um if you want to find reviewers I would certainly suggest that you do um but it's not required so a reviewer might be somebody not part of your group or organization that would also use your

proposal I haven't read your proposal so I couldn't even give you a like a hint uh but some examples like for nfts we generally recommend reaching out to the open C Discord um there's also an nft working group for like core eips to deal with client things we recommend you talk to client developers so the idea is during the review state or status the authors go out and find people to look at their EIP what if they're satisfied with the reviews and they don't think there's going to be any more changes you can open a PR to move it into last call then there's a period usually two weeks and then you will put another PR to move it into final so to be extremely clear here it's up to you guys to open the PRS to

move them into the next status whenever you think you're ready to do it okay fantastic uh thank you very much um and I guess that would um like essentially answer the questions also for six eight uh 6809 which is also ours okay cool yeah so I can go through these um I think this is a fairly long yeah so I won't go through this on the call but I'll put it on my to-do list for something to take a look at um six eight oh eight um you don't have to do that now uh just just one more question about the opening

PRS so this one will be merged and then we'll have to Fork another uh another repository and then open another PR hey you won't need to Fork a whole other repository you can just reuse the same the same Repository um if if the edits are small you can actually do it right in the GitHub website there's a button for it and everything um if it's a larger edit I'd recommend you know using the git command line or a GUI and doing it that way okay got it thanks just a suggestion uh I use sync Fork options in GitHub to sync our fork for our VIP so you could also also do that and Branch out from there as well

yeah yeah um yeah we are using uh search three for forget uh git repository but yeah thanks a small tip if you don't use the master branch of your fork so notice that you are using the master Branch here um GitHub GitHub rather has an option to keep Master up to date um and then you can just create branches off of that um yeah so just generally not yeah yeah we thought about implementing the the git flow but it was a let's say it trial and error because there were a lot of Errors from from the validated

and we just wanted to have them fixed okay yeah that's why we use this management perfect I guess that in the end we'll do a squash merger something like that yeah it'll it'll get squashed when we do the merge through GitHub so don't worry about having a bunch of commits yep sounds good thanks so there is another proposal along with the with this one like between mentioned 6809 Sam if you would like to take that a look as well later or now it's fine yeah okay so this is going to be

similarly large I think yeah yep that's on it's it's from us as well so yeah you don't have to do that now because it's pretty lengthy perfect okay yeah yeah thanks for thanks for coming hopefully I answered your questions and you know feel free to ping me if um you have any more thing thanks all right the next one is six eight two eight The Proposal is in the last call have shared the link in the chat yeah sure give me one second I'm just gonna

poke my rabbit here get out of here all right possible energies all right foreign yeah I think I remember this one it

doesn't look like it's changed significantly so that's that's good thousand yeah yeah okay you've uh doubled and triple checked your interface ID so 5 Seconds of three five seven instead of three okay I'm going to assume your solidity is decent because I wouldn't be able to review it otherwise anyways so uh catalog okay good foreign

ERS nicely I'm never sure if the line continuation stuff looks good yeah yeah the this uh backslash has solves it perfect okay let's go take a quick look at your assets zero foreign I mean that's okay we we generally don't allow um like can like build system configuration anymore but it's not I'm not super strict about it yeah this

looks very reasonable good uh is that anything in here like gpg or anything like that nothing there I have to worry about no perfect okay yeah it looks good thank you awesome oh we do have another question about another proposal of ours sure so we rewrote 6381 um so the initially it was an extension

to be able to emote to so it's already merged because we're the authors and um yeah so initially it was meant as an extension for uh 721 for EAP 721 but upon rewrite we you really don't need to implement 721 in order to use it so we removed it from the required eaps that's okay right yeah that's totally fine okay cool cool so then that's all for from us thank you no no problem follow the next one is um six six seven two it's in draft

status yeah okay foreign all the checks are passing perfect foreign that's perfect all right

foreign PR or Erp um please mention it in chat otherwise we'll just keep going through the stuff on the agenda right we do have some for final and for last caller all right so I already took a look at 3525 before the call that looks like a bot problem so I'm just going to save that for Panda let's take a look at this one here foreign foreign

hmm okay so what is the actual specification here so we need to change your final EIP things get a little bit difficult because we have to balance like the immutability of a family IP like the fact that it won't change once it's published against the usability of the EIP if it's completely broken then there's no point in keeping a broken standard around so um okay from

what is the call data okay all right so we'll leave that one

all right to last call so I guess that's our motivation that looks good unless you implement the following interface okay that's the last thing purchased event

okay collection of things item offer okay reference implementation

yeah that all looks good and then what did panda say nothing okay and then is there anything going on in the discussion thread is the last thing we need to check again nothing recent so so if you can go to approve

all right let's move a few things into review then right all right let's have some failing let's take that off all right so I was talking to um youth dreamer about this on Discord um so basically the the problem with this proposal is that e4444 um is only a draft so this proposal can't move forward to uh review um

and there's not really much I can do about that okay your checks look good give this a wreath the based permission personal role system based on base okay um

probably a bit based permission enrollment system each permission strippers every single bit okay foreign okay

so I'm just transported okay and then down here security

considerations foreign

I have a question about 4881 not this one if we are done with this yep okay so for 4881 it seems like it's an interface proposal but it does not have a four four four four in request section it just mentioned it as for security consideration that um with this proposal deposit Q can exceed like when 444 will be effective so I'm wondering if he just removes this mention of like this particular criteria will that be okay because uh okay okay so just to remove that because I don't see any dependency on four fours yeah

you could you could absolutely reward it to be like furthermore if any proposed like furthermore might be possible in the future to remove the historical deposit logs or something like that so yeah you can just make it generic as long as you don't specifically mention uh four fours okay makes sense thank you all right foreign yeah okay so that one needs to be done

before this one okay things okay foreign

foreign foreign it's fine for now

foreign okay so that all reads like motivation good everything good tap into creation okay a specification

section good okay foreign foreign

okay Okay so 63.57 okay um so this is six three five seven six three five seven okay

yeah okay that seems fine so we will approve so that was six three five seven one six three one five we made good progress today yeah yeah a lot of these are are small here okay this is probably need to read this separately 631 pictures it

submit this change foreign

okay which I think this one's still waiting on one yes this is just waiting on the validator there's no there's nothing for me to actually do here

okay cool and then so uh validator fixing right yep okay okay contract address and what for you around we'll then find the address for

contradiction following steps okay so there's actually a some three seven seven zero okay uh we need to go on all and we need keys foreign

foreign that's basically it for this otherwise I think it's fine and then we have to go and leave a comment on here okay foreign

foreign all right cool looks like we have covered everything for yesterday for today awesome that's perfect I'll have a few minutes security for my next call thanks for coming out everybody and we'll see you all in two weeks thank you Sam thank you thank you