EIP Editing Office Hour #1

Transcript

welcome to the first eip editing office r thanks to everyone who joined and before we go ahead with today's officer let me first congratulate all the eip authors behind the merger paid we have bellatrix activated this morning so a huge congratulations to mikhail kalanin dani ryan vitalik buterin eip editors client implementation team and everyone supporting the upgrade so um continuing to support eip authors we have started this eip editing office hour and the main goal here is to invite

all the current authors as well as aspiring authors to show up on this meeting if they have any questions or concerns or anything they would like to learn about the eap editing or the eip process in terms of changing from one status to another thank you to sam wilson for volunteering for this and helping out with the questions that may be coming up from eap authors so yeah let me just invite him to maybe provide a basic details of how eips are written in general common mistakes and maybe pro tips and after that we can pick up some new proposals which have

been submitted in the past week in the eips github repository so welcome sam hey thanks puja so uh i guess i'm going to be talking about um eap editing um and i'll be here to answer any questions for authors that want to drop in and say hi um always feel free to interrupt me if you have a question or something you want to talk about specifically say your your eip but yeah so i guess some of the biggest issues that we see in eip editing are just not following the template correctly um not filling out the uh preamble properly um

you know obviously spelling and grammar or something that comes up pretty often and um mixing up the motivation and rationale section so uh the those are probably some of the biggest easiest mistakes that people make and um you know over the next couple of meetings or whatever we'll probably see some examples of that if um and yeah but yeah the eip process shouldn't be too onerous um and and i know it's a kind of a long process to get through for for um proposals so we kind of want to make it easier for everybody and you know that's why i'm here so drop in ask questions and we'll hopefully be able to get you through the process quicker thanks thank you sam that is quite an advice

like uh yes these are the common mistakes and i hope that this can be less seen in future and uh yeah come up with your questions so uh maybe for today we can start with couple of uh proposals which are entrapped some it's totally up to you if you would like to screen share or we can just quickly discuss i can list the numbers of pull requests there we go is that working it is maybe you would like to refresh that i have added a few more oh okay and there we go okay

so i guess let's dive right in with uh 5568. all right so i think right off the bat we have a title here that isn't descriptive enough

um i think we could do a little bit better so so one thing that i try to do is is kind of soften my pr comments a little bit um yeah i end up saying i think this a lot and they're usually required so all right it's always hard figuring out how long

to make titles because they they do have a very strict character limit um so yeah titles are like hard for eips let's see so well-known revert reason hmm so that's probably too long let's find out

you wouldn't happen to know the limit off hand would you pooja i think it's like 50 characters or 44 characters no i don't uh so this is 46 and if we do one okay yeah sorry going on a bit of a detour here [Laughter] well i guess that's that's helpful like it's a good piece of information even

i'm missing on that so it is 44 characters hmm there we go

all right signature wallet of action is needed by returning customer workout that's pretty reasonable author is good we have a discussions two link that's good all right interface interface so what is an interface eip um so

method names contract apis yep that makes sense okay oh okay oftentimes the smart contract needs

to signal into a wallet that an action needs to be taken such as to sign a transaction or send hd request for your traditions logic to the front end this lens cpls contract itself to request the action this means that for example and change your mark you can directly tell the wallet to produce interesting okay wow the instruction idea of an instruction

defined by an erp must be a type eip number the ap must define exactly zero one instruction id the structure of the instruction data for any instruction id must be defined by the eip that defines the instruction id that's interesting um okay before submitting a transaction to the mempool it must be evaluated in a local fork for the chain if it reverts and has reason starting with the bytes 15 c0 then it must be treated as a signal to parse the second describe the first two bytes okay

i think so that's technically like a um uh like content feedback and i should probably be putting on the discussion thread but um you know what i will because we we try to use the pull request only for um like feedback on the formatting and and like not on the content then and the discussion throughout the content so that makes sense because every time they

will be coming up with new pull requests once thanks yeah okay um okay

okay that seems pretty reasonable and then what else there was something else i wanted to say um now who is this there okay so

yeah now what do i have to talk about here oh there's a lot of stuff on here all right cool that's easy chain specific addresses who wrote this is it yeah this is somebody else okay where is the link to what eip is this

i love when people don't put their eips in here keep two scale [Music] seems very old 2021 yeah yeah specification change-specific address foreign um

well i'll just skip this one for now yeah i have added a new proposal i mean a new poll request which is a proposal to move to the final status so if you can refresh that maybe you will get it sure uh do you know the number for that one no two five yeah okay we can look at that one yeah these ones are always hairy um so what is this doing this is moving okay this is moving one of panda's eips so we're past the last call deadline

so we have changes so changes in last call generally should reset the last call timer um okay motivation so there's not that much changed in it's false okay so it's just unwrapping some text okay that's good

sub domain by index and total sub domains so this seems like a an actual like functional change so since this is uh all right sam looks like there is a comment uh related to this particular 4834 in chat okay i'm sorry i didn't even notice chat was going on here yeah not a problem and that's why i thought of mentioning it so it looks like um

panda and uh victor discussed whether 137 one should or should not be included yeah i kind of skipped over that um so i'm of the stance that unless it's required reading to implement the eip you don't need to put it in the requires header um other eip editors have a different stance on that um it just really hasn't been formalized um [Music] yeah that's fine i mean looks like if uh the

author uh has he put it in mandatory i mean he was in uh required like 20 and 173 and they removed it so okay yeah okay all right

cool so looks mostly fine um yeah just needs a few other little changes there process stuff all right oh you want to do five four six six sure we can do that okay

so yeah we're just waiting on three more approvals that's because this is an update to eip1 right yeah exactly got it thank you sorry for interruption here oh now we can go ahead with that um one other one is about the last call pull request number is 5506. if you can refresh you will find it five five zero six all right let's take a look at this one

here wide wide 2612. so what's going on with this one needs approval from mr chico so we're just waiting on an approval from mr chico yeah that's all okay do we need do we need uh like a dual approval or is it because this approval was not on the github that's why we are looking for uh so it's because um mr chico approved it um and then they changed it after so it

removed his approval so now we have to wait for his approval again yeah yeah i wish people would just add themselves as authors more often like if mr chico is not responding like quickly this uh frangio person should be adding themselves as an author yeah yeah i mean we we can have champions we i mean need not have others all the time there are times when champions can move the proposals forward yeah maybe i'll say that so and uh my if my understanding is correct

when this is again coming up or with updates we may have to revisit and change the last call date and they tried oh god yep [Music] oh that's annoying i can't wait till we get the bot doing that um yeah that would be helpful all right

so we can do this other status change here that's an easy one let's go and see the full file okay trades for special nf teams uh with ownership of predetermined immutable burn authorization so yeah so

so defines the interfacing tokens before instruments both parties have to agree on who has the authorization to put this token for an authorization c the authorization of brandon's targeting

okay so there's an interface cool okay non-transferable okay that's all seem fine backwards compatibility yeah i mean that seems fine i'm okay with this moving to review okay

i think that covers our status change um we can go with the rest of the open phone requests sounds good vegetable tokens has a method of distributing digital receipts for fidget purposes oh um

oh all right digital receipts let's pull this up okay of course 721 so missing be proposed to receive transactions totally simple

okay so two important questions about this proposal now a chain one

okay transaction flow because refresh is an item from online retailer checking out leads the customer to an option to mint nft the smart contract provides the user with a digital receipt now token when fulfilling the order the retailer will upload the digital receipt specifically below is the metadata to the previously mentioned nmt so it's a period and the json scheme is composed of two parts so it's giving a title details for the receipt for example vendor and those keyword options requiring the line items contained in the receipt all right

all right i'm just going to assume this is valid json schema because that's fine mine items okay uh communion previous tools to show our receipts the new property receipt contains a new provider receipt structure and the signature property requires the vendor to digitally sign the receipt structure interesting um so this is more of a question that goes over here [Music] and by the the only

address that can update the meta data okay digitally set the receipt structure oh

okay title supply date for my date stream okay so okay 21. let's create considerations okay yeah it seems fine um yeah this looks fine to me i think we can go ahead as it well other than the comments i left i think we can go ahead

as a draft so there we go and then we can close that and then going on to the next erp 73 yeah if you will refresh i think all the proposals that you have already looked into you can reject find it yeah cool all right this has already had some discussion on it all right let's see

[Music] four three six two okay so we've got some eip number problems great i love when that happens um okay okay [Music] all right all right okay so no discussion about the eip

number so we're gonna go and do that so this will be five five seven three okay um

you okay 5573 how is that actually formalizing and

with ethereum oh my god they picked like the most complicated way of capitalizing this that's all right which is still in review status yeah yeah that's fine they're they're getting it through i think okay so let's see how long this is it's probably too long so this go away chat 46 so you're a little bit too long

um yeah i'm just calling it signing with ethereum without cap grog mark down render it for you also i think it's useful to include yep i have a question here so it seems

like this is a new proposal right yep and they are trying to uh like have it from siwe like extension of that proposal yep there we go um okay description we need the same capitalization and we can

do that okay so um i'm not sure if this is appropriate but i would like to make a mention uh looks like uh the other editor um so the author may have originally written s-i-w-e um cap quark extension okay capabilities it is with eip number and then we are writing it sign in with ethereum so yeah we can definitely have siwe capabilities right if they want to have it yeah i think siwe is isn't um common yeah i get that yeah that makes sense yep

yeah i can add that to my um so we'll change this to sign in with ethereum in the title clear choices that's sad uh isn't um there we go

okay so consistent capitalization um there's some on top of sun with ethereum form form consent to telecom capabilities with an extensible scope okay authors are good good sound ethereum describe cell three of accounts authenticate without changing services relying parties by studying standard method format described by scope session details security mechanism all right so there's definitely some changes here that need to be made okay so

sign in with ethereum describes how okay looks like spelling of ethereum is not right in the first or second line the sorry spelling of ethereum is right i think it's right oh yeah it is right it is showing red yeah um actually i'll be right back just give me one second sorry yeah sure no problem

okay sorry about that okay so first um okay so four three six one four three six one about signing with the ram

um okay this specification describes this proposal describes a mechanism on top of sound with a theme to give informed consent to get delegate capabilities for this delegate isn't that isn't the term delegate seems like i yeah

i was wondering if this is a new term they have coined for [Music] looks like that is a term okay but just an uncommon one right so it says that it refers to an employee independent contractor or agent of user

okay so it's not necessarily the wrong term right okay um together how to delegate with capabilities however key authenticates against target resource is out of scope um of this specification out of scope for the specification and depends on the implementation throughout your resource so then with ethereum

uh how do i want to do this i think something like this would probably be the best so dot slash eip 4361.md and then um yeah so that ap four three six one we're signing with

ethereum swipes out through your accounts authenticate with blockchain services good morning okay and cap rocks okay so term [Music] perhaps in the abstract

foreign okay so specification specifications three different audiences um see foreign

um [Music] complying with the specification in essence containers we'll tap quote uri in the resources section and the corresponding cap rocks name independent yeah okay so

standard okay cow cropped uri type of urine or a certain name space that resolves to a caprock details object cap capcom details object adjacent object describing the actions and optionally the resources associated with calculators and namespace okay resource service into this provider so my biggest problem with the signing with ethereum people is that it's like they're writing specifications like for a formal system as opposed to like ethereum eip so they have a completely different style

and i'm not exactly sure how to convey that to the authors i i may be in touch with the authors i have invited them for peeps so if there is uh anything that needs to be positively signaled to them it's not super important it's just the way they write specifications is like uh like an old school like rfc like very jargon heavy and it's like eaps are generally written more accessibly um there's nothing like like technically wrong with it it's just style um [Music] okay okay cap ground sweet

specification defines the following caprock is in recap rock is an erp 4361 message followed a specific form that allows the three recap together okay all right so that's fine the finest this iww message fields are used to further from the scope of all capital capabilities so we are very close to time and okay

i think uh there are a couple of points that i would like to mention about this proposal that you are reviewing as the sam was mentioning earlier about the common mistakes one of those is the eip number allocation so yeah if you yeah if you are listening to this uh recording and you are an eip author you must not attempt to assign the eip number and this cannot be any random number this is an eip editors drop so please leave it for them to assign it and another important note here i uh see this proposal is dependent it has a required section which contains another proposal which is in review that

is not in final status so it may be fine for this proposal to get merged as draft but when it comes to last call or moving towards final it is very important that the proposal on which your proposal is dependent must be in final status so please work with authors of proposal whom you want to be like as a required section in your proposal yeah and that's what i wanted to mention about it and i think it was good uh session today this was the very first session for eip editing office hours so authors this is specially dedicated for you

please take advantage of this time provided by eip editors and do join us i will try to share information on ech github as an agenda and also in the related channels of cataracts discord thank you sam wilson thank you victor and everybody else joining us today thanks for having me see y'all in two weeks